Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFmxBT Update to 24.0 #1026

Merged
merged 3 commits into from
Dec 12, 2023
Merged

RFmxBT Update to 24.0 #1026

merged 3 commits into from
Dec 12, 2023

Conversation

alenkani
Copy link
Contributor

@alenkani alenkani commented Dec 11, 2023

What does this Pull Request accomplish?

Updates niRFmxBT in grpc-device to 24.0
Updated manually niRFmxBt_exclude.h file to skip property specific Set/Get APIs as per the design.

Why should this Pull Request be merged?

Updated to match the upcoming release of niRFmxBt 24.0.0
There are Lot of apis rearranged because of Code clean Up

What testing has been done?

Manually inspected generated files.
Copied files from grpc-device-scrapigen/out/rfmxBT/export/ to grpc-device/source/codegen/metadata/nirfmxBT/ and built grpc-device successfully.
Manually inspected nirfmxbt.proto file.

@alenkani alenkani changed the title RFmxBT Scrapigen Update to 24.0 RFmxBT Update to 24.0 Dec 11, 2023
Copy link
Collaborator

@reckenro reckenro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Waiting to see if we can avoid the binary-breaking change.

@maxxboehme
Copy link
Collaborator

@alenkani are you wanting to have this PR included in the 2.4 release of grpc-device or can it wait for the next. We are currently in the process of releasing grpc-device for 2.4 today.

@reckenro reckenro merged commit aeef999 into main Dec 12, 2023
10 of 11 checks passed
@reckenro reckenro deleted the users/alenka/btdevice branch December 12, 2023 23:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants