Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(signals): remove selectSignal and rename withSignals to withComputed #4075

Merged
merged 1 commit into from
Oct 19, 2023

Conversation

markostanimirovic
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

  • The selectSignal function is removed in favor of computed that has equality check by reference in v17
  • withSignals is renamed to withComputed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Oct 18, 2023

Deploy Preview for ngrx-io ready!

Name Link
🔨 Latest commit 47f8652
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/653063fcd7917100083a392d
😎 Deploy Preview https://deploy-preview-4075--ngrx-io.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@brandonroberts brandonroberts merged commit 25f95bc into main Oct 19, 2023
5 checks passed
@brandonroberts brandonroberts deleted the feat/signals/remove-select-signal branch October 19, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants