Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(data): allow 0 to be a valid key #3830

Merged
merged 1 commit into from
Apr 5, 2023
Merged

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3828

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[ ] No

Other information

@netlify
Copy link

netlify bot commented Apr 4, 2023

Deploy Preview for ngrx-io canceled.

Name Link
🔨 Latest commit 818c736
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/642c6534f22560000807e967

@markostanimirovic markostanimirovic merged commit e50126d into master Apr 5, 2023
@markostanimirovic markostanimirovic deleted the fix/data-0-as-key branch April 5, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: should be a single entity key - with 0 as EntityKey
3 participants