Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(entity): remove addAll #2783

Merged
merged 2 commits into from
Nov 15, 2020
Merged

feat(entity): remove addAll #2783

merged 2 commits into from
Nov 15, 2020

Conversation

timdeschryver
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Other information

BREAKING CHANGE:

To overwrite the entities, we previously used the addAll method but the method name was confusing.

BEFORE:

adapter.addAll(action.entities, state);

AFTER:

The new method name setAll describes the intention better.

adapter.setAll(action.entities, state);

BREAKING CHANGE:

To overwrite the entities, we previously used the `addAll` method but the method name was confusing.

BEFORE:

```ts
adapter.addAll(action.entities, state);
```

AFTER:

The new method name `setAll` describes the intention better.

```ts
adapter.setAll(action.entities, state);
```
@timdeschryver timdeschryver changed the title feat(entity): remove add all feat(entity): remove addAll Nov 12, 2020
@ngrx ngrx deleted a comment Nov 13, 2020
@alex-okrushko alex-okrushko merged commit 93a4754 into master Nov 15, 2020
@timdeschryver timdeschryver deleted the pr/entity-remove-add-all branch November 16, 2020 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants