feat(effects): limit retries to 10 by default

[alex-okrushko]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

Limit the number of retries to 10 by default

What kind of change does this PR introduce?

Removes infinite loop if the effect is producing errors on every retry

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #2303

What is the new behavior?

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

[ngrxbot]

Preview docs changes for 14e7c34 at https://previews.ngrx.io/pr2376-14e7c34/

[brandonroberts]

The changes LGTM. Is it correct that if you want to only change the number of retries, you still have to re-implement the default behavior plus that change?

[alex-okrushko]

Is it correct that if you want to only change the number of retries, you still have to re-implement the default behavior plus that change?

One can provide the custom effects error handler like this:

@NgModule({
  imports: [EffectsModule.forRoot([MovieEffects])],
  providers: [
    {
      provide: EFFECTS_ERROR_HANDLER,
      useValue: customEffectResubscriptionHandler,
    },
    
  ],
})

// adjust the number of retries
const CUSTOM_NUMBER_OF_RETRIES = 100; 

export function customEffectResubscriptionHandler<T extends Action>(
  observable$: Observable<T>,
  errorHandler: CustomErrorHandler
): Observable<T> {
  return defaultEffectsErrorHandler(observable$, errorHandler, CUSTOM_NUMBER_OF_RETRIES);
}

Thank means that there's no need to reimplement the behavior if one wants to increase the retries number.

[timdeschryver]

I find that the above snippet can be added to the docs.
If you agree, I can open up a PR for it 🙂

[alex-okrushko]

Good idea @timdeschryver