Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Schematic for customisable error handling migration #2335

Conversation

zakhenry
Copy link
Contributor

@zakhenry zakhenry commented Jan 25, 2020

PR Checklist

Please check if your PR fulfills the following requirements:

- [ ] Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[x] Other... Please describe: Migration schematic to migrate breaking change introduced in effects.

What is the current behavior?

#2295 introduces a breaking change, this PR adds a migration to ease the transition to ngrx@9 for developers.

Closes #

What is the new behavior?

On upgrade to ngrx 9 developers can run the migration to automatically fix the renamed configuration variable

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

This PR is pending the merge of #2295, thus it currently contains those commits.

@zakhenry zakhenry changed the title Feat/customisable error handling migration Schematic for customisable error handling migration Jan 25, 2020
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jan 25, 2020

Preview docs changes for eefe761 at https://previews.ngrx.io/pr2335-eefe761/

modules/effects/migrations/9_0_0/index.ts Outdated Show resolved Hide resolved
modules/effects/migrations/9_0_0/index.ts Outdated Show resolved Hide resolved
@zakhenry zakhenry force-pushed the feat/customisable-error-handling-migration branch 2 times, most recently from 82c0f47 to a4b7e47 Compare January 26, 2020 18:00
@zakhenry zakhenry force-pushed the feat/customisable-error-handling-migration branch from a4b7e47 to fe07ddb Compare January 27, 2020 14:33
@zakhenry
Copy link
Contributor Author

Rebased on master now that the dependent PR has merged.

@timdeschryver
Copy link
Member

I like this approach more in comparison to what we first had 👏

@zakhenry zakhenry force-pushed the feat/customisable-error-handling-migration branch from fe07ddb to eefe761 Compare January 27, 2020 20:31
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@brandonroberts brandonroberts merged commit 93b4081 into ngrx:master Jan 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants