Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(effects): createEffect returns specific type for dispatch false #2195

Merged
merged 1 commit into from
Nov 6, 2019
Merged

feat(effects): createEffect returns specific type for dispatch false #2195

merged 1 commit into from
Nov 6, 2019

Conversation

alex-okrushko
Copy link
Member

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

based of #2194

createEffect with {dispatch: false} now returns whatever Observable type is actually returned (instead of unknown).

[ ] Bugfix
[x] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

createEffect with {dispatch: false} returns Observable<unknown>.

What is the new behavior?

createEffect with {dispatch: false} returns Observable<SpecificType>.

Does this PR introduce a breaking change?

[x] Yes
[ ] No

Somewhat. If anyone was relying that Observable<unknown> is returned. However, Observable<SpecificType> can be always widened to Observable<unknown> so it shouldn't really break anything.

Other information

@ngrxbot
Copy link
Collaborator

ngrxbot commented Oct 30, 2019

Preview docs changes for dcaf89d at https://previews.ngrx.io/pr2195-dcaf89d/

@alex-okrushko
Copy link
Member Author

Rerunning the tests should fix the issue. (I do not have permissions at circle ci)

modules/effects/src/effect_creator.ts Outdated Show resolved Hide resolved
modules/effects/src/effect_creator.ts Show resolved Hide resolved
modules/effects/src/effect_notification.ts Outdated Show resolved Hide resolved
modules/effects/src/effect_creator.ts Outdated Show resolved Hide resolved
@brandonroberts
Copy link
Member

@alex-okrushko this one needs another pass on the merge conflicts.

@brandonroberts brandonroberts merged commit f70600f into ngrx:master Nov 6, 2019
jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants