Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(schematics): fix effects code generated by schematics:feature #1357

Merged

Conversation

krzysztof-grzybek
Copy link
Contributor

Variables names in Effects should be consistent across whole file.

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Issue Number: #1356

What is the new behavior?

ng generate @ngrx/schematics:feature customName generates Effects code correctly.

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

Variables names in Effects should be consistent across whole file.
@coveralls
Copy link

Coverage Status

Coverage remained the same at 88.4% when pulling 9f5dc15 on krzysztof-grzybek:schematics-effects-foo-fix into 41a0d45 on ngrx:master.

Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@brandonroberts brandonroberts merged commit 458e2b4 into ngrx:master Oct 16, 2018
@brandonroberts
Copy link
Member

Thanks @krzysztof-grzybek!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants