Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: cron-nft-ttr workflow no longer has staging/prod env matrix #1999

Merged
merged 1 commit into from
Jun 20, 2022
Merged

fix: cron-nft-ttr workflow no longer has staging/prod env matrix #1999

merged 1 commit into from
Jun 20, 2022

Conversation

gobengo
Copy link
Contributor

@gobengo gobengo commented Jun 17, 2022

Motivation

  • when checking on this new cronjob, I noticed that there were two jobs running instead of one. https://github.com/nftstorage/nft.storage/actions/runs/2517588405
    • this is unintended and because I copypastad the env matrix
    • it's probably a good idea to matrix this across production and staging envs, but that wasn't my original intention so want to remove this asap. we can add a staging check later once we know the check is working/useful against prod

@gobengo gobengo requested a review from alanshaw June 17, 2022 20:38
@gobengo gobengo marked this pull request as ready for review June 17, 2022 20:38
@cloudflare-workers-and-pages
Copy link

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: 6dc481d
Status: ✅  Deploy successful!
Preview URL: https://8bfb1924.nft-storage-1at.pages.dev
Branch Preview URL: https://1655498158-cron-nft-ttr-rm-m.nft-storage-1at.pages.dev

View logs

@gobengo gobengo merged commit 1c37be5 into main Jun 20, 2022
@gobengo gobengo deleted the 1655498158-cron-nft-ttr-rm-matrix branch June 20, 2022 18:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alanshaw alanshaw alanshaw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gobengo @alanshaw