Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI: Validate images across platforms #130

Merged
merged 2 commits into from
Mar 21, 2023
Merged

CI: Validate images across platforms #130

merged 2 commits into from
Mar 21, 2023

Commits on Mar 21, 2023

  1. CI: Validate images across platforms 

    Start off by checking software in which versions are known to be
time-varying.

Co-authored-by: Thomas Sibley <tsibley@fredhutch.org>
    @victorlin @tsibley
    victorlin and tsibley committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    dab9103 View commit details
    Browse the repository at this point in the history

  2. Use trap instead of set -x 

    This allows errors such as "command not found" to terminate the script.

Other options which were considered:

1. Set BASH_XTRACEFD to separate lines from `set -x`. Did not use this
   because the option isn't available on bash <4.0, which is where the
   default bash version of macOS is tied to indefinitely.
2. Use trap but without the intermediate function. This gets a bit ugly
   when used inside the literal string due to the need to escape quotes.
    @victorlin
    victorlin committed Mar 21, 2023
    Configuration menu
    Copy the full SHA
    1856139 View commit details
    Browse the repository at this point in the history