Remove deprecation on open method #936
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skjnldsv
force-pushed
the
fix/open-deprecation
branch
from
a0c8087
to
5fb8946
Compare
|
/compile amend / |
skjnldsv
added
3. to review
npmbuildbot-nextcloud
bot
force-pushed
the
fix/open-deprecation
branch
from
5fb8946
to
b3eba95
Compare
|
Has been there for 17 months (b313993). Looks good to me. |
|
/compile amend / |
beardhatcode
approved these changes
Jun 5, 2021
|
Makes sense to me. These are the uses of the old syntax i found: Also... maybe this should be noted in the app upgrade guide |
azul
added a commit
to nextcloud/officeonline
that referenced
this pull request
Jun 5, 2021
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore.
3 tasks
azul
added a commit
to nextcloud/officeonline
that referenced
this pull request
Jun 5, 2021
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore. Signed-off-by: Azul <azul@riseup.net>
azul
added a commit
to nextcloud/recommendations
that referenced
this pull request
Jun 5, 2021
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore. Signed-off-by: Azul <azul@riseup.net>
azul
added a commit
to nextcloud/deck
that referenced
this pull request
Jun 5, 2021
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore. Signed-off-by: Azul <azul@riseup.net>
4 tasks
azul
approved these changes
Jun 5, 2021
|
skjnldsv
added
4. to release
This bot does not rebase 😉 |
skjnldsv
added
3. to review
npmbuildbot-nextcloud bot
pushed a commit
to nextcloud/recommendations
that referenced
this pull request
Jun 5, 2021
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore. Signed-off-by: Azul <azul@riseup.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
juliusknorr
approved these changes
Jun 10, 2021
|
Needs another rebase 🙈 |
All replaced already thanks to @azul 🚀 |
59 tasks
This was referenced Jun 16, 2021
|
conflicts |
skjnldsv
force-pushed
the
fix/open-deprecation
branch
from
b3eba95
to
3534262
Compare
|
/compile amend / |
Signed-off-by: John Molakvoæ (skjnldsv) <skjnldsv@protonmail.com> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
nextcloud-command
force-pushed
the
fix/open-deprecation
branch
from
3534262
to
5595638
Compare
thaitv21
pushed a commit
to VTS-WORKSPACE/recommendations
that referenced
this pull request
Mar 10, 2022
With nextcloud/viewer#936 and Nextcloud 22 the old syntax will not be supported anymore. Signed-off-by: Azul <azul@riseup.net> Signed-off-by: npmbuildbot-nextcloud[bot] <npmbuildbot-nextcloud[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: John Molakvoæ (skjnldsv) skjnldsv@protonmail.com