[stable28] fix: use filename to find current index #2118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![backportbot-nextcloud[bot]](https://github.com/avatars/in/21012?s=60&v=4){kind=small}
The viewer component is usually used with a folder and the basename unique. However in photos, the fileList contains objects from multiple folders and the basename is not always unique. How to reproduce: - Create folder A and B - Upload an image to folder A and name it "Test" - Upload another image to folder B and also name it "Test" - Open photos - Click on the image from folder B - The image from folder A is shown To find the correct "currentIndex" we need filename (including the path). Signed-off-by: Daniel Kesselberg <mail@danielkesselberg.de>
|
/compile |
skjnldsv
approved these changes
Jan 9, 2024
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
blizzz
approved these changes
Jan 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2112