Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable28] fix: make prev and next slides not focusable and aria-hidden #2117

Merged
merged 3 commits into from
Jan 5, 2024

Conversation

But it doesn't work on a video slide, as it re-mounts the container and loses attributes.

Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@backportbot-nextcloud backportbot-nextcloud bot added accessibility bug Something isn't working labels Jan 5, 2024
@skjnldsv skjnldsv changed the base branch from backport-2091-stable28 to stable28 January 5, 2024 11:06
@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2024

Ah! it worked 😁

@skjnldsv skjnldsv changed the title [backport-2091-stable28] fix: make prev and next slides not focusable and aria-hidden [stable28] fix: make prev and next slides not focusable and aria-hidden Jan 5, 2024
@skjnldsv
Copy link
Member

skjnldsv commented Jan 5, 2024

/compile

@ShGKme
Copy link
Contributor

ShGKme commented Jan 5, 2024

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@ShGKme ShGKme merged commit 960baa1 into stable28 Jan 5, 2024
29 checks passed
@ShGKme ShGKme deleted the backport/2091/backport-2091-stable28 branch January 5, 2024 17:02
@ShGKme ShGKme added this to the Nextcloud 28.0.2 milestone Jan 5, 2024
@ShGKme ShGKme added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jan 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release Ready to be released and/or waiting for tests to finish accessibility bug Something isn't working
Projects
None yet
3 participants