Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add option to disable sidebar #1782

Merged
merged 1 commit into from
Jul 6, 2023

Conversation

artonge
Copy link
Contributor

@artonge artonge commented Jul 6, 2023

This PR adds an option to prevent the Viewer from interacting with the sidebar when its opened. It also hides the "Open sidebar" button from the header.

For nextcloud/server#39171

Todo:

  • Maybe add tests

Signed-off-by: Louis Chemineau <louis@chmn.me>
@artonge artonge self-assigned this Jul 6, 2023
@artonge artonge requested a review from skjnldsv July 6, 2023 15:11
@artonge artonge added 3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket labels Jul 6, 2023
@artonge artonge modified the milestones: Nextcloud 27.0.2, Nextcloud 28 Jul 6, 2023
@skjnldsv skjnldsv merged commit eb03d53 into master Jul 6, 2023
27 checks passed
@skjnldsv skjnldsv deleted the artonge/feat/add_enableSidebar_option branch July 6, 2023 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review Waiting for reviews enhancement New feature or request javascript Javascript related ticket
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants