Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix sidebar opening for different dav root and non-dav files #1416

Merged
merged 1 commit into from
Oct 24, 2022
Merged

Fix sidebar opening for different dav root and non-dav files #1416

merged 1 commit into from
Oct 24, 2022

Conversation

skjnldsv
Copy link
Member

@skjnldsv skjnldsv commented Oct 14, 2022 •
edited
Loading

@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature 3. to review Waiting for reviews labels Oct 14, 2022
@skjnldsv skjnldsv added this to the Nextcloud 26 milestone Oct 14, 2022
@skjnldsv skjnldsv self-assigned this Oct 14, 2022
@skjnldsv
Copy link
Member Author

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 14, 2022
@skjnldsv skjnldsv mentioned this pull request Oct 15, 2022
Closed
@szaimen szaimen requested review from artonge, a team, PVince81 and szaimen and removed request for a team October 22, 2022 07:10
@skjnldsv skjnldsv added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Oct 22, 2022
@skjnldsv skjnldsv added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Oct 22, 2022
@skjnldsv
Copy link
Member Author

Ready for reviews

@skjnldsv skjnldsv added the high High priority label Oct 22, 2022
PVince81
PVince81 approved these changes Oct 24, 2022
View reviewed changes
Copy link
Member

@PVince81 PVince81 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 code looks fine, an extra safety would be nice, see comment

src/utils/davUtils.js Outdated Show resolved Hide resolved
@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 24, 2022
@skjnldsv
Fix sidebar opening for different dav root and non-dav files
0db4bbd 
Signed-off-by: John Molakvoæ <skjnldsv@protonmail.com>
@szaimen szaimen requested a review from artonge October 24, 2022 10:44
@szaimen szaimen merged commit 8506bc6 into master Oct 24, 2022
@szaimen szaimen deleted the fix/sidebar-open branch October 24, 2022 10:53
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 24, 2022
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Oct 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PVince81 PVince81 PVince81 approved these changes

@artonge artonge artonge approved these changes

@szaimen szaimen Awaiting requested review from szaimen

Assignees

@skjnldsv skjnldsv

Labels
4. to release Ready to be released and/or waiting for tests to finish bug Something isn't working high High priority regression Regression of a previous working feature
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.

Photos 2.0 Can't Delete photo from single view Open sidebar unveils an empty panel
4 participants
@skjnldsv @PVince81 @artonge @szaimen