Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression: Use preview for unsupported images (fix #1408) #1409

Merged
merged 1 commit into from
Oct 13, 2022
Merged

Fix regression: Use preview for unsupported images (fix #1408) #1409

merged 1 commit into from
Oct 13, 2022

Conversation

pulsejet
Copy link
Member

I think this needs to take priority before NC 25 is released with broken HEIC support.

@skjnldsv @szaimen

@szaimen szaimen added the 3. to review Waiting for reviews label Oct 10, 2022
@szaimen szaimen added this to the Nextcloud 26 milestone Oct 10, 2022
@szaimen szaimen requested a review from artonge October 10, 2022 20:32
@pulsejet pulsejet force-pushed the patch-heic branch 2 times, most recently from 0b0c24b to 48fb2df Compare October 10, 2022 22:28
@pulsejet pulsejet mentioned this pull request Oct 11, 2022
Closed
9 tasks
skjnldsv
skjnldsv reviewed Oct 11, 2022
View reviewed changes
src/components/Images.vue Outdated Show resolved Hide resolved
@szaimen szaimen requested a review from skjnldsv October 11, 2022 16:27
@skjnldsv
Copy link
Member

/rebase

@skjnldsv
Copy link
Member

/compile amend /

@skjnldsv
Copy link
Member

/backport to stable25

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 12, 2022
@skjnldsv skjnldsv added bug Something isn't working regression Regression of a previous working feature medium Medium priority and removed backport-request Pending backport by the backport-bot labels Oct 12, 2022
@skjnldsv
Copy link
Member

Btw there will also be this to fix

viewer/src/models/images.js

Lines 29 to 38 in ff759ac

const mimes = [
'image/bmp',
'image/heic',
'image/heif',
'image/jpeg',
'image/png',
'image/tiff',
'image/webp',
'image/x-xbitmap',
]

I can tackle that a bit later :)

@skjnldsv
Copy link
Member

Seems the compile bot didn't want to work.
let me tackle that now then

@skjnldsv skjnldsv added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Oct 12, 2022
@pulsejet @skjnldsv
Use preview for unsupported images (fix nextcloud#1408)
797bb49 
Signed-off-by: Varun Patil <varunpatil@ucla.edu>
@skjnldsv skjnldsv merged commit 703227a into nextcloud:master Oct 13, 2022
@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
@backportbot-nextcloud backportbot-nextcloud bot mentioned this pull request Oct 13, 2022
Merged
1 task
@backportbot-nextcloud backportbot-nextcloud bot removed the backport-request Pending backport by the backport-bot label Oct 13, 2022
@skjnldsv
Copy link
Member

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request Pending backport by the backport-bot label Oct 13, 2022
@backportbot-nextcloud
Copy link

The backport to stable24 failed. Please do this backport manually.

@pulsejet pulsejet mentioned this pull request Oct 19, 2022
Closed
@pulsejet pulsejet deleted the patch-heic branch October 19, 2022 02:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@skjnldsv skjnldsv skjnldsv approved these changes

@ChristophWurst ChristophWurst Awaiting requested review from ChristophWurst

@artonge artonge Awaiting requested review from artonge

Assignees
No one assigned
Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request Pending backport by the backport-bot bug Something isn't working medium Medium priority regression Regression of a previous working feature
Projects
None yet
Milestone
Nextcloud 26
Development

Successfully merging this pull request may close these issues.
3 participants
@pulsejet @skjnldsv @szaimen