eliminate more phantom users

[jmcclelland]

Thanks for the fix on phantom users. Unfortunately, after pulling in your changes and un-doing my initial PR, I'm still getting phantom users. This time it's from the preferences table and is pulled in when you count actions.

[kesselb]

Thanks @jmcclelland 👍

The first version used a wrapper for setting the fields and made sure the user id exists.

nickvergessen, who wrote the app, pointed out that the app may process a lot of data and therefore the check should only run for the shares table, where a deleted share_initiator, is a valid state.

For preferences, it's not a valid state and on user deletion all preferences for a given uid should be removed.

[jmcclelland]

Ahhh - Thanks for the feedback. I'm guessing this may be a bug with user_external or perhaps our implementation of it. We seem to have preferences for hundreds of users that have been deleted. I'll resolve our data integrity problems and close this PR.

[github-actions]

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)