chore: Upgrade @nextcloud/vue + @nextcloud/password-confirmation + @nextcloud/dialogs #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Pytal
commented
Oct 27, 2023
Pytal
commented
- Upgrade @nextcloud/vue + @nextcloud/password-confirmation + @nextcloud/dialogs + vue + vue-template-compiler
- Migrate to new APIs
- Fix build and runtime errors
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
- Remove deprecated setModal method - Remove unnecessary style import - Adapt filter to new Node API Signed-off-by: Christopher Ng <chrng8@gmail.com>
- Fix dialogs output path - Add nonce to fix CSP violation Signed-off-by: Christopher Ng <chrng8@gmail.com>
Signed-off-by: Christopher Ng <chrng8@gmail.com>
artonge
approved these changes
Nov 2, 2023
| @@ -1,6 +1,9 @@ | |||
| const path = require('path') | |||
| const webpackConfig = require('@nextcloud/webpack-vue-config') | |||
|
|
|||
| // Let webpack determine automatically where it's located | |||
| webpackConfig.output.publicPath = 'auto' | |||
There was a problem hiding this comment.
Why is this not enough ?
https://github.com/nextcloud-libraries/webpack-vue-config/blob/master/webpack.config.js#L48
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.