feat(cli)!: Export to final destination directly #402
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Christopher Ng <chrng8@gmail.com>
come-nc
approved these changes
May 2, 2023
4 tasks
tcitworld
reviewed
May 17, 2023
| IUserManager $userManager, | ||
| UserMigrationService $migrationService, | ||
| ITempManager $tempManager | ||
| private IUserManager $userManager, |
There was a problem hiding this comment.
issue: This PHP 8.0+ syntax will not work with PHP7.4, which is the oldest version supported with NC 25.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export directly to a
.partfile in the final destination and rename on completion<uid>_<timestamp>.zip.part→<uid>_<timestamp>.zipPreviously the partial archive was created in a temp folder then moved on completion to the specified folder and we now get the date timestamp before starting the export instead of after