Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show estimated export size and display exportability warnings #136

Merged
merged 12 commits into from
Jun 10, 2022
Merged

Show estimated export size and display exportability warnings #136

merged 12 commits into from
Jun 10, 2022

Conversation

Pytal
Copy link
Member

@Pytal Pytal commented Apr 30, 2022 •
edited
Loading

To Do

  • Try out combinations

Screenshots

Estimated size

image

Warning

image

Requires

@Pytal Pytal added 3. to review Waiting for reviews enhancement New feature request labels Apr 30, 2022
@Pytal Pytal added this to the 1.1 milestone Apr 30, 2022
@Pytal Pytal requested review from PVince81 and come-nc April 30, 2022 01:57
@Pytal Pytal self-assigned this Apr 30, 2022
@Pytal Pytal mentioned this pull request Apr 30, 2022
Closed
2 tasks
@Pytal Pytal force-pushed the enh/add-export-estimation branch 2 times, most recently from f8c2260 to 3858dd9 Compare June 3, 2022 00:42
@Pytal Pytal force-pushed the enh/exportable-ui branch 4 times, most recently from 620b604 to b057cb6 Compare June 4, 2022 00:40
@Pytal Pytal added 2. developing Work in progress and removed 3. to review Waiting for reviews labels Jun 4, 2022
@Pytal Pytal changed the title Check exportability and display warnings Show estimated export size and display exportability warnings Jun 7, 2022
@Pytal Pytal added 3. to review Waiting for reviews and removed 2. developing Work in progress labels Jun 7, 2022
@Pytal Pytal force-pushed the enh/add-export-estimation branch from 48ae999 to 85c551b Compare June 8, 2022 01:12
@Pytal Pytal force-pushed the enh/exportable-ui branch 2 times, most recently from 018f2de to a575f1e Compare June 9, 2022 02:43
@come-nc
Copy link
Collaborator

come-nc commented Jun 9, 2022

(did not test)

Base automatically changed from enh/add-export-estimation to main June 10, 2022 02:28
@Pytal
Add function to check exportability
64c7cb8 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Update error message
867933b 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Update error message
e65a172 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Check if data is exportable and display warnings
83f977f 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Use error handler
129b525 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Fix eslint errors
8831ddb 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Handle empty array
30533f2 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Display estimated export size
129e013 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Use MiB in not exportable message
c1f4d48 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Build js
1e51add 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Update endpoint data handling
300a885 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Round to a whole number and set a minimum
23ba2a0 
Signed-off-by: Christopher Ng <chrng8@gmail.com>
@Pytal
Copy link
Member Author

Pytal commented Jun 10, 2022

After discussing with @come-nc the estimated size has been changed from MiB with one significant digit to a whole number in MiB

Precision may be tweaked in a separate PR if needed

@Pytal Pytal added 4. to release Ready to be released and/or waiting for tests to finish and removed 3. to review Waiting for reviews labels Jun 10, 2022
@Pytal
Copy link
Member Author

Pytal commented Jun 10, 2022

/backport to stable24

@backportbot-nextcloud backportbot-nextcloud bot added the backport-request A backport was requested for this pull request label Jun 10, 2022
@Pytal Pytal merged commit 5e29023 into main Jun 10, 2022
@Pytal Pytal deleted the enh/exportable-ui branch June 10, 2022 02:55
@backportbot-nextcloud
Copy link

backportbot-nextcloud bot commented Jun 10, 2022 •
edited by Pytal
Loading

The backport to stable24 failed. Please do this backport manually.

#174

@Pytal Pytal mentioned this pull request Jun 10, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@come-nc come-nc come-nc approved these changes

@PVince81 PVince81 Awaiting requested review from PVince81

Assignees

@Pytal Pytal

Labels
4. to release Ready to be released and/or waiting for tests to finish backport-request A backport was requested for this pull request enhancement New feature request
Projects
None yet
Milestone
1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@Pytal @come-nc