Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable29] fix: Correctly check result of function #557

Merged
merged 1 commit into from
May 16, 2024
Merged

[stable29] fix: Correctly check result of function #557

merged 1 commit into from
May 16, 2024

Conversation

backportbot[bot]
Copy link

@backportbot backportbot bot commented May 15, 2024 •
edited by nickvergessen
Loading

Backport of #556

Warning, This backport's changes differ from the original and might be incomplete ⚠️

Todo

  • Review and resolve any conflicts
  • Amend HEAD commit to remove the line stating to skip CI

Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

@backportbot backportbot bot requested a review from nickvergessen May 15, 2024 08:30
@backportbot backportbot bot added this to the Nextcloud 29.0.1 milestone May 15, 2024
@nickvergessen
fix: Correctly check result of function
c76fcaf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen marked this pull request as ready for review May 15, 2024 08:38
@blizzz
Copy link
Member

blizzz commented May 15, 2024 

[✘] Check for expected files failed
      The following extra files have been found:
          LICENSES
          .reuse

This is 30 only, and the updater master branch deals with it correctly.

@blizzz blizzz requested a review from Altahrim May 15, 2024 09:54
@skjnldsv skjnldsv mentioned this pull request May 15, 2024
Merged
21 tasks
@nickvergessen
Copy link
Member

This is 30 only, and the updater master branch deals with it correctly.

I guess it should not test against master in stable branches... same for the PHP versions

@blizzz
Copy link
Member

blizzz commented May 15, 2024

@Altahrim and I discussed that today and we think the same.

@nickvergessen nickvergessen merged commit bbb3fee into stable29 May 16, 2024
18 of 22 checks passed
@nickvergessen nickvergessen deleted the backport/556/stable29 branch May 16, 2024 08:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen approved these changes

@come-nc come-nc come-nc approved these changes

@blizzz blizzz Awaiting requested review from blizzz

@skjnldsv skjnldsv Awaiting requested review from skjnldsv

@Altahrim Altahrim Awaiting requested review from Altahrim

Assignees

@nickvergessen nickvergessen

Labels
3. to review
Projects
None yet
Milestone
Nextcloud 29.0.1
Development

Successfully merging this pull request may close these issues.
3 participants
@blizzz @nickvergessen @come-nc