Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable Text to be used by Viewer outside Files app #732

Merged
merged 2 commits into from
Apr 20, 2020
Merged

Enable Text to be used by Viewer outside Files app #732

merged 2 commits into from
Apr 20, 2020

Commits on Apr 20, 2020

  1. Remove unused property 

    OCA.Text.Files is not used in the Text, Viewer or Files app.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    edbb47d View commit details
    Browse the repository at this point in the history

  2. Enable Text to be used by Viewer outside Files app 

    Since Nextcloud 18.0.4 the Files app triggers the "LoadViewer" event, so
that event can be used to register Text with Viewer instead of doing it
through the "OCA\Files::loadAdditionalScripts" event.

Besides being more correct for the Files app it also makes possible to
use Text when opening files through Viewer in other apps, like Talk.

Note, however, that in public share pages Text is still opened using the
fallback actions instead of through Viewer, as Viewer currently does not
provide the share token of the public shared folder that contains the
file to be opened.

Signed-off-by: Daniel Calviño Sánchez <danxuliu@gmail.com>
    @danxuliu
    danxuliu committed Apr 20, 2020
    Configuration menu
    Copy the full SHA
    1061537 View commit details
    Browse the repository at this point in the history