Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Migrate to files:node:updated #6427

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

luka-nextcloud
Copy link
Contributor

@luka-nextcloud luka-nextcloud commented Sep 18, 2024

📝 Summary

🖼️ Screenshots

🏚️ Before 🏡 After
B A

🚧 TODO

  • ...

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests
  • Documentation (README or documentation) has been updated or is not required

Signed-off-by: Luka Trovic <luka@nextcloud.com>
@mejo-
Copy link
Member

mejo- commented Sep 19, 2024

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

@luka-nextcloud
Copy link
Contributor Author

@luka-nextcloud what's the background for this change? Does it fix anything? Is it a technical dept thing?

Sorry for not mentioning. This is a technical debt, I've added the issue on the description.

@mejo-
Copy link
Member

mejo- commented Sep 23, 2024

Thanks for the additional context @luka-nextcloud. Do you know what the emitted event is supposed to do? I.e. is there a reproducer of how to test whether this works?

@luka-nextcloud
Copy link
Contributor Author

@mejo- The emitted event is supposed to notify the other apps that a file was updated. Install text app and notes app (with this PR nextcloud/notes#1377) then open notes app to edit a note.

Copy link
Member

@juliusknorr juliusknorr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small comment

id: this.fileId,
source: generateRemoteUrl(`dav/files/${user.uid}${this.relativePath}`),
mtime: new Date(),
mime: 'text/markdown',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The text app might also handle other mime types, so we should take the one that the viewer passes along to us

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: 👀 In review
Development

Successfully merging this pull request may close these issues.

Migrate to files:node:updated
3 participants