Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(TaskList): Add class name to rendered HTML #6323

Merged
merged 1 commit into from
Sep 10, 2024
Merged

Conversation

mejo-
Copy link
Member

@mejo- mejo- commented Sep 6, 2024

The upstream Tiptap tasklist implementation uses data-type attributes to identify task lists and task items. We use class names instead as we depend on the markdown-it-task-lists plugin.

This fixes copy & paste of task lists.

Fixes: #5237

🏁 Checklist

  • Code is properly formatted (npm run lint / npm run stylelint / composer run cs:check)
  • Sign-off message is added to all commits
  • Tests (unit, integration and/or end-to-end) passing and the changes are covered with tests

@mejo- mejo- added bug Something isn't working 3. to review labels Sep 6, 2024
@mejo- mejo- self-assigned this Sep 6, 2024
The upstream Tiptap tasklist implementation uses data-type attributes to
identify task lists and task items. We use class names instead as we
depend on the markdown-it-task-lists plugin.

This fixes copy & paste of task lists.

Fixes: #5237

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- merged commit fb29f2f into main Sep 10, 2024
59 of 61 checks passed
@mejo- mejo- deleted the fix/paste_task_list branch September 10, 2024 06:34
@mejo-
Copy link
Member Author

mejo- commented Sep 10, 2024

/backport to stable30

@mejo-
Copy link
Member Author

mejo- commented Sep 10, 2024

/backport to stable29

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review bug Something isn't working
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

Copy & paste of todo/task lists result in bulletpoints
2 participants