Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[stable28] fix(a11y): contrast for active menubar buttons #5171

Merged
merged 4 commits into from
Dec 28, 2023
Merged

[stable28] fix(a11y): contrast for active menubar buttons #5171

merged 4 commits into from
Dec 28, 2023

Commits on Dec 28, 2023

  1. fix(a11y): contrast for active menubar buttons 

    Dropdown menus (headings and callouts) are still low contrast.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    d880a9c View commit details
    Browse the repository at this point in the history

  2. fix(style): according to feedback in PR 

    * Use default (white) text in active buttons in light mode.
* Add a 2px margin between menubar buttons to have a bit of spacing
  when two buttons are active next to each other.

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    81522e4 View commit details
    Browse the repository at this point in the history

  3. fix(style): no padding between menu buttons on mobile 

    Also fix the computation of the number of slots available

Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    9b7fd3e View commit details
    Browse the repository at this point in the history

  4. fix(cy): format test with actions in overflow menu 

    Signed-off-by: Max <max@nextcloud.com>
    @max-nextcloud @juliusknorr
    max-nextcloud authored and juliusknorr committed Dec 28, 2023
    Configuration menu
    Copy the full SHA
    18fbb0c View commit details
    Browse the repository at this point in the history