Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "tmp: skip known attachment failures" #4904

Merged
merged 2 commits into from
Nov 30, 2023
Merged

Revert "tmp: skip known attachment failures" #4904

merged 2 commits into from
Nov 30, 2023

Conversation

juliusknorr
Copy link
Member

@juliusknorr juliusknorr commented Oct 26, 2023

This reverts commit 66d5c7d

Further commit fixes the tests, isolates them a bit more and moves file operations from clicking through UI to actual API calls.

This reverts commit 66d5c7d.

Signed-off-by: Julius Härtl <jus@bitgrid.net>
Signed-off-by: Julius Härtl <jus@bitgrid.net>
@juliusknorr juliusknorr marked this pull request as ready for review November 30, 2023 13:51
@juliusknorr juliusknorr added tests If you write them we ♥ you 3. to review labels Nov 30, 2023
Copy link
Member

@mejo- mejo- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, much cleaner tests now! Probably worth being backported to stable28, no?

@mejo- mejo- merged commit b9e1311 into main Nov 30, 2023
37 checks passed
@mejo- mejo- deleted the revert/test-skip-2 branch November 30, 2023 17:15
@mejo-
Copy link
Member

mejo- commented Nov 30, 2023

/backport to stable28

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3. to review tests If you write them we ♥ you
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants