ci(node): do not install cypress as we do not need it. #4747
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Max <max@nextcloud.com>
max-nextcloud
force-pushed
the
ci/no-cypress-in-node-build
branch
from
42dfcc0
to
ad1730a
Compare
|
Just testing this... might as well upstream it into the nextcloud workflow templates. Here's the docs for the env variable: https://docs.cypress.io/guides/references/advanced-installation#Skipping-installation |
|
Yes!! please upstream it! 🚀 |
|
Opening nextcloud/.github#220 instead... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📝 Summary
Avoid installing an unnecessary dependency that sometimes even fails the build due to network issues.
🏁 Checklist
npm run lint/npm run stylelint/composer run cs:check)