-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: hotkey ctrl-s #4400
fix: hotkey ctrl-s #4400
Conversation
Passing run #10752 โ๏ธ
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
545da35
to
95e5602
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Works like a charm. Also fixes the same issue in Collectives.
Signed-off-by: Luka Trovic <luka@nextcloud.com>
95e5602
to
111853b
Compare
/compile |
/backport 111853b to stable27 |
/backport 111853b to stable26 |
/backport 111853b to stable25 |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
The backport to stable25 failed. Please do this backport manually. # Switch to the target branch and update it
git checkout stable25
git pull origin stable25
# Create the new backport branch
git checkout -b fix/foo-stable25
# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts. Resolve them.
git cherry-pick abc123
# Push the cherry pick commit to the remote repository and open a pull request
git push origin fix/foo-stable25 More info at https://docs.nextcloud.com/server/latest/developer_manual/getting_started/development_process.html#manual-backport |
manual backport of #4400 Signed-off-by: Jonas <jonas@freesources.org>
Manual backport to stable25: #4419 |
@luka-nextcloud: I just saw that we still have old code in place that adds the "mod-s" shortcut to our keymap extension. This should be superfluous now. Could you please open a follow-up PR that removes it? text/src/components/Editor.vue Lines 505 to 508 in b7008d9
|
๐ Summary
๐ผ๏ธ Screenshots
๐ง TODO
๐ Checklist
npm run lint
/npm run stylelint
/composer run cs:check
)