Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable25] Shrink heading anchor links to 1em, fixes links in headings #3852

Merged
merged 2 commits into from
Feb 28, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

@backportbot-nextcloud backportbot-nextcloud bot commented Feb 28, 2023

  • ⚠️ This backport had conflicts and is incomplete

backport of #3847

In readonly mode, the heading anchor links spanned the whole width so
far, overlaying potential links in headings.

Fixes: #3822

Signed-off-by: Jonas <jonas@freesources.org>
@backportbot-nextcloud backportbot-nextcloud bot added the bug Something isn't working label Feb 28, 2023
@backportbot-nextcloud backportbot-nextcloud bot added this to the Nextcloud 25.0.5 milestone Feb 28, 2023
@mejo-
Copy link
Member

mejo- commented Feb 28, 2023

/compile

@max-nextcloud
Copy link
Collaborator

Nice Catch! 🎣

@cypress
Copy link

cypress bot commented Feb 28, 2023

1 flaky tests on run #8786 ↗︎

0 99 0 0 Flakiness 1

Details:

Merge 886fd3a into bae4cd4...
Project: Text Commit: d9be2bd3d3 ℹ️
Status: Passed Duration: 05:51 💡
Started: Feb 28, 2023 5:15 PM Ended: Feb 28, 2023 5:21 PM
Flakiness  cypress/e2e/links.spec.js • 1 flaky test

View Output Video

Test
test link marks > link preview > shows a link preview Screenshot

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@max-nextcloud max-nextcloud merged commit 78b2a3d into stable25 Feb 28, 2023
@delete-merged-branch delete-merged-branch bot deleted the backport/3847/stable25 branch February 28, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants