[stable23] npm audit fix #3640
Merged
[stable23] npm audit fix #3640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Julius Härtl <jus@bitgrid.net>
juliusknorr
force-pushed
the
deps/npm-audit/stable23
branch
from
a07dd07
to
5a49157
Compare
juliusknorr
requested review from
a team,
marcelklehr and
max-nextcloud
and removed request for
a team
max-nextcloud
approved these changes
Jan 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making npm audit happy
Manually patching package-lock for using json5 1.0.2 in the following dependency tree:
json5 <1.0.2 || >=2.0.0 <2.2.2
Severity: high
Prototype Pollution in JSON5 via Parse Method - GHSA-9c47-m6qq-7p4h
Prototype Pollution in JSON5 via Parse Method - GHSA-9c47-m6qq-7p4h
fix available via
npm audit fix --forceWill install vue-jest@4.0.1, which is a breaking change
node_modules/find-babel-config/node_modules/json5
node_modules/json5
node_modules/loader-utils/node_modules/json5
node_modules/tsconfig-paths/node_modules/json5
find-babel-config *
Depends on vulnerable versions of json5
node_modules/find-babel-config
vue-jest 1.0.0 - 3.0.7
Depends on vulnerable versions of find-babel-config
node_modules/vue-jest
The suggested fix did break the tests but the manual bump seems to work fine even with the breaking json5 version from 0.x to 1.x