Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP: Test also CommonMark serialization #3331

Closed
wants to merge 2 commits into from
Closed

WIP: Test also CommonMark serialization #3331

wants to merge 2 commits into from

Commits on Nov 30, 2023

  1. Test also markdown serialization 

    As two different markdown strings can be semantically the same,
we can test if the resulting rendered HTML are syntactically equal.

Currently about hundred test cases fail because of a known limitation of
`prosemirror-markdown` not able to serialize nested marks correctly, see
ProseMirror/prosemirror-markdown#82

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux @juliusknorr
    susnux authored and juliusknorr committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    2e30ee5 View commit details
    Browse the repository at this point in the history

  2. Remove hacky testing of commonmark parsing testing 

    The commonmark parsing tests are already done by markdownit,
as suche we only need to test serializing. And of cause parsing of
markdown extensions we added.

The current "CommonMark" testing also had quite a lot of hacks
as even if we are commonmark compatible we do not yield the same html
representation (html is only a interim stage to tiptap).

Signed-off-by: Ferdinand Thiessen <rpm@fthiessen.de>
    @susnux @juliusknorr
    susnux authored and juliusknorr committed Nov 30, 2023
    Configuration menu
    Copy the full SHA
    c804604 View commit details
    Browse the repository at this point in the history