-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: relative link in RichWorkspace #3269
Merged
vinicius73
merged 3 commits into
master
from
fix/noid/invalid-relative-link-rich-workspace
Oct 27, 2022
Merged
Fix: relative link in RichWorkspace #3269
vinicius73
merged 3 commits into
master
from
fix/noid/invalid-relative-link-rich-workspace
Oct 27, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinicius73
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 18, 2022 14:06
b5b6e3c
to
7fb2374
Compare
/backport to stable25 |
juliusknorr
approved these changes
Oct 18, 2022
/rebase |
nextcloud-command
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 19, 2022 13:47
7fb2374
to
9f3f50d
Compare
/rebase |
nextcloud-command
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 20, 2022 11:14
9f3f50d
to
953aa61
Compare
/rebase |
nextcloud-command
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 27, 2022 13:26
953aa61
to
6ee94ab
Compare
/compile amend / |
skjnldsv
approved these changes
Oct 27, 2022
nextcloud-command
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 27, 2022 13:28
6ee94ab
to
db6ae58
Compare
|
I will fix the rebase |
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
vinicius73
force-pushed
the
fix/noid/invalid-relative-link-rich-workspace
branch
from
October 27, 2022 16:39
db6ae58
to
0c53443
Compare
/compile |
Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
delete-merged-branch
bot
deleted the
fix/noid/invalid-relative-link-rich-workspace
branch
October 27, 2022 17:25
The backport to stable25 failed. Please do this backport manually. |
/backport 403fe2e,0c534433236b575c16e209b2314c48c18a7a128c to stable25 |
1 task
Ah, sorry @vinicius73. The backport of the two commits was successful though: #3323. Feel free to take over 😊 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To reproduce:
demo.md
file inside folder BReadme.md
file in the folder A/A/B/demo.md
Expected behavior
The rich workspace must open
/A/B/demo.md
instead of/B/demo.md
.