Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: relative link in RichWorkspace #3269

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

vinicius73
Copy link
Member

@vinicius73 vinicius73 commented Oct 17, 2022

To reproduce:

  • Create a folder A
  • Create a folder B inside the folder A
  • Create a demo.md file inside folder B
  • Create an Readme.md file in the folder A
  • In Rich Workspace, create a link to an inline file in /A/B/demo.md
  • Try to open this link

Expected behavior

The rich workspace must open /A/B/demo.md instead of /B/demo.md.

@vinicius73 vinicius73 added bug Something isn't working 3. to review labels Oct 17, 2022
@vinicius73 vinicius73 force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from b5b6e3c to 7fb2374 Compare October 18, 2022 14:06
@vinicius73 vinicius73 added this to the Nextcloud 25.0.1 milestone Oct 18, 2022
@vinicius73 vinicius73 marked this pull request as ready for review October 18, 2022 14:09
@vinicius73
Copy link
Member Author

/backport to stable25

@vinicius73
Copy link
Member Author

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from 7fb2374 to 9f3f50d Compare October 19, 2022 13:47
@vinicius73
Copy link
Member Author

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from 9f3f50d to 953aa61 Compare October 20, 2022 11:14
@skjnldsv
Copy link
Member

/rebase

@nextcloud-command nextcloud-command force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from 953aa61 to 6ee94ab Compare October 27, 2022 13:26
@skjnldsv
Copy link
Member

/compile amend /

@nextcloud-command nextcloud-command force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from 6ee94ab to db6ae58 Compare October 27, 2022 13:28
@skjnldsv
Copy link
Member

/home/runner/work/text/text/cypress/e2e/workspace.spec.js
Error:   157:3  error  'menuBubbleButton' is not defined  no-undef

@vinicius73
Copy link
Member Author

I will fix the rebase

Vinicius Reis added 2 commits October 27, 2022 13:04
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
Signed-off-by: Vinicius Reis <vinicius.reis@nextcloud.com>
@vinicius73 vinicius73 force-pushed the fix/noid/invalid-relative-link-rich-workspace branch from db6ae58 to 0c53443 Compare October 27, 2022 16:39
@juliusknorr
Copy link
Member

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@vinicius73 vinicius73 merged commit 7fd67d7 into master Oct 27, 2022
@delete-merged-branch delete-merged-branch bot deleted the fix/noid/invalid-relative-link-rich-workspace branch October 27, 2022 17:25
@backportbot-nextcloud
Copy link

The backport to stable25 failed. Please do this backport manually.

@mejo-
Copy link
Member

mejo- commented Oct 27, 2022

/backport 403fe2e,0c534433236b575c16e209b2314c48c18a7a128c to stable25

@vinicius73
Copy link
Member Author

backport must be done manually @mejo-, since link feature have changed in #2665

@mejo-
Copy link
Member

mejo- commented Oct 27, 2022

Ah, sorry @vinicius73. The backport of the two commits was successful though: #3323. Feel free to take over 😊

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4. to release bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants