-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: mention search issues #3068
Conversation
LGTM; Is it possible to have tests for it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for looking into it @luka-nextcloud! I agree with @vinicius73 that we should have tests for that.
lib/Controller/UserApiController.php
Outdated
@@ -10,6 +10,7 @@ | |||
use OCP\IUserManager; | |||
use OCP\IUserSession; | |||
use OCP\Share\IShare; | |||
use Psr\Log\LoggerInterface; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a leftover to me :)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you see this comment @luka-nextcloud?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, just realized that you fixed it in a follow-up commit.
3a81d1c
to
2209f6f
Compare
/backport to stable25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks a lot @luka-nextcloud, works as expected now ❤️
@luka-nextcloud also, please fix the code style issues reported by php-cs-fixer (see PHP linting CI job). |
b095bcb
to
96f515a
Compare
@mejo- Please check again :) |
96f515a
to
e8e3d15
Compare
e2a01b4
to
934ff3a
Compare
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Luka Trovic <luka@nextcloud.com>
Signed-off-by: Jonas <jonas@freesources.org>
934ff3a
to
609719e
Compare
Signed-off-by: Luka Trovic luka@nextcloud.com
Summary