Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable24] Make it possible to insert heif/heic images #2975

Merged
merged 2 commits into from
Sep 26, 2022

Conversation

julien-nc
Copy link
Member

Manual backport of #2972

I don't know why but explicit heic/heif mime types have to be added in the <input>.
They are not shown with image/*.

If such files are inserted and the preview provider is not enabled (or does not work), Text behaves just like if we insert a corrupted image.

@julien-nc julien-nc added this to the Nextcloud 24.0.6 milestone Sep 20, 2022
@julien-nc julien-nc changed the title make it possible to insert heif/heic images [stable24] Make it possible to insert heif/heic images Sep 20, 2022
@julien-nc
Copy link
Member Author

/compile

@@ -24,7 +24,7 @@
<div class="menubar" :class="{ 'show': isVisible, 'autohide': autohide }">
<input ref="imageFileInput"
type="file"
accept="image/*"
accept="image/*, image/heic, image/heif"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why it is necessary?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't know why but explicit heic/heif mime types have to be added in the <input>.
They are not shown with image/*.

@julien-nc julien-nc force-pushed the backport/stable24/heic-heif-support branch from 131463e to 2919e45 Compare September 22, 2022 10:00
@julien-nc
Copy link
Member Author

/compile

Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
@julien-nc julien-nc force-pushed the backport/stable24/heic-heif-support branch from dbc7a38 to b38d87f Compare September 25, 2022 20:52
@julien-nc
Copy link
Member Author

/compile

Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
@juliusknorr juliusknorr merged commit fdcf2fc into stable24 Sep 26, 2022
@delete-merged-branch delete-merged-branch bot deleted the backport/stable24/heic-heif-support branch September 26, 2022 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants