-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Insert images from local device (or link) #1900
Conversation
b0e0099
to
93d7fa5
Compare
83db5a1
to
45662f3
Compare
0bc9115
to
15936b6
Compare
2d72f6c
to
fafdf8d
Compare
This now includes "attachment folder" changes. It's been rebased on master (so it must be used in NC 24). The TODO list in this PR's description has been updated. |
lib/Service/ImageService.php
Outdated
return null; | ||
} | ||
if ($imageFile instanceof File) { | ||
// return $imageFile; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- To be discussed if we still need the original file for gif support for example
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This has been changed and will work if we want to support GIFs. If the mime type is not supported by the preview generator, the original file is returned now. This also fixes the svg display because there is no related preview provider by default.
/compile amend |
1f9cef4
to
1a9bfc4
Compare
I don't mind to merge now and add cypress tests later (if we don't forget about it 😬). But the failing psalm tests should be tackled first, no? |
69b91e2
to
4879432
Compare
/compile amend |
Signed-off-by: Julien Veyssier <eneiluj@posteo.net> Signed-off-by: nextcloud-command <nextcloud-command@users.noreply.github.com>
4879432
to
dea3a59
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Super nice work 👌
Filed #2049 for the cypress tests |
Is this also ready for clients via our DirectEditingMobileInterface? |
@tobiasKaminsky All related endpoints are public and use the session edition token and optionally the public share token to authenticate.
I'll make a PR to fix the 2 image serving issues. |
…hareToken, use the edition session to get the user ID Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
…hareToken, use the edition session to get the user ID Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
This is possible, as we do it with Collabora. In this regard, we have this nextcloud/server#16132, but want to wait for your side (move RichDocuments to directEditing) |
…hareToken, use the edition session to get the user ID Signed-off-by: Julien Veyssier <eneiluj@posteo.net>
Fixes #58
Here is a basic implementation of 2 new options to insert images:
In both cases, the image is then stored in the
/Text
directory which is created if it does not exist.An alternative mentioned in #58 (comment) would be to store uploaded images in a directory next to the markdown file.
Todo
Gifcording 😁