Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Nextcloud 31] Text does not work on public shares #6324

Closed
susnux opened this issue Sep 6, 2024 · 1 comment · Fixed by #6339
Closed

[Nextcloud 31] Text does not work on public shares #6324

susnux opened this issue Sep 6, 2024 · 1 comment · Fixed by #6339
Assignees
Labels
1. to develop bug Something isn't working
Milestone

Comments

@susnux
Copy link
Contributor

susnux commented Sep 6, 2024

Describe the bug

With Nextcloud 31 public shares also use the same UI as the files app, meaning the legacy UI is dropped in favor of the new (Nextcloud 28) Vue UI.
Sadly the text app does not work out-of-the-box, meaning if you open a public share and then open a markdown file (any file that text can open) the app fails to show the file.
The problem seems that Text does not detect the public share correctly and thus calls the wrong entry point to create a session.

Maybe you can use this functions for public share detection / share token retrieval if needed:
https://nextcloud-libraries.github.io/nextcloud-sharing/modules/public.html

To Reproduce
Steps to reproduce the behavior:

  1. Use the master branch (Nextcloud 31)
  2. Create a public share
  3. Put a MD file inside
  4. Open public share
  5. Try to view the markdown file

Expected behavior
Text can open and view / edit the file as with Nextcloud 30 and before.

Screenshots

Bildschirmaufnahme_20240906_164408.webm
XHRPUT
http://localhost:8081/index.php/apps/text/session/251/create
[HTTP/1.1 401 Unauthorized 28ms]

	
fileId	251
filePath	"/Neue Textdatei.md"
forceRecreate	false
guestName	""
token	null

Server details:

  • Nextcloud version: 31
  • PHP Version: 8.3
@susnux susnux added bug Something isn't working 1. to develop labels Sep 6, 2024
@susnux susnux added this to the Nextcloud 31 milestone Sep 6, 2024
mejo- added a commit that referenced this issue Sep 9, 2024
Fixes: #6324

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue Sep 9, 2024
Fixes: #6324

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- closed this as completed in 122ba83 Sep 10, 2024
@susnux
Copy link
Contributor Author

susnux commented Sep 10, 2024

Thank you @mejo- for awesomely fast fixing this 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop bug Something isn't working
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

2 participants