Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Display links inserted from smart picker as preview per default #5838

Closed
mejo- opened this issue May 27, 2024 · 1 comment · Fixed by #5846
Closed

Display links inserted from smart picker as preview per default #5838

mejo- opened this issue May 27, 2024 · 1 comment · Fixed by #5846
Assignees
@mejo-
Labels
29 feedback bug Something isn't working design Experience, interaction, interface, … discuss

Comments

@mejo-
Copy link
Member

mejo- commented May 27, 2024

Describe the bug
Right now, inserting links inserts them as text links per default, which makes sense. When inserting via smart picker, we should change the default to display the link as preview though, as that's what people expect after seeing the preview in the smart picker already. Even more so for options in the smart picker where you can select between link and content preview (like for references to Nextcloud Tables).

This was originally suggested in issue nextcloud/collectives#1298

@max-nextcloud @nextcloud/designers what do you think?
@mejo- mejo- added bug Something isn't working design Experience, interaction, interface, … discuss 29 feedback labels May 27, 2024
@mejo- mejo- self-assigned this May 27, 2024
@mejo- mejo- mentioned this issue May 27, 2024
Closed
mejo- added a commit that referenced this issue May 29, 2024
@mejo-
fix(SmartPicker): Show smart picker links as preview per default
dbc28c7 
Fixes: #5838

Signed-off-by: Jonas <jonas@freesources.org>
mejo- added a commit that referenced this issue May 29, 2024
@mejo-
fix(SmartPicker): Show smart picker links as preview per default
f53e454 
Fixes: #5838

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- mentioned this issue May 29, 2024
Merged
3 tasks
@mejo- mejo- mentioned this issue Jun 12, 2024
Closed
@Aveyron-RetD
Copy link

My 2 cents.
=> On a new line smart picker = preview automatically
=> inside a line = link

Well this is what i do for formatting.

mejo- added a commit that referenced this issue Jun 18, 2024
@mejo-
fix(SmartPicker): Show smart picker links as preview per default
f88e45e 
Fixes: #5838

Signed-off-by: Jonas <jonas@freesources.org>
@mejo- mejo- closed this as completed in bc5f65c Jun 18, 2024
backportbot bot pushed a commit that referenced this issue Jun 18, 2024
@mejo- @backportbot
fix(SmartPicker): Show smart picker links as preview per default
3d8726b 
Fixes: #5838

Signed-off-by: Jonas <jonas@freesources.org>
@NikoKS NikoKS mentioned this issue Aug 7, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mejo- mejo-

Labels
29 feedback bug Something isn't working design Experience, interaction, interface, … discuss
Projects
📝 Office team
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(SmartPicker): Insert smart picker links as preview per default nextcloud/text
2 participants
@mejo- @Aveyron-RetD