Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require optional CI checks to succeed #2372

Closed
max-nextcloud opened this issue May 6, 2022 · 3 comments · Fixed by #5189
Closed

Require optional CI checks to succeed #2372

max-nextcloud opened this issue May 6, 2022 · 3 comments · Fixed by #5189
Assignees
Labels
1. to develop enhancement New feature or request feature: integration help wanted Extra attention is needed

Comments

@max-nextcloud
Copy link
Collaborator

Github can only require CI checks to always succeed. If they do not run because a path filter is in effect the merge will be blocked.

https://github.com/dorny/paths-filter#conditional-execution could enable conditionally running actions and still require them.

@vinicius73
Copy link
Member

@juliusknorr
Copy link
Member

Started playing with this in nextcloud/richdocuments#2518 one thing we might need is another job at the end that builds a summary and still passes if jobs are skipped.

@mejo-
Copy link
Member

mejo- commented Nov 1, 2022

Given that we still have flaky Cypress tests from time to time, I'm not sure whether we want to make them mandatory in the first place 🤔

@max-nextcloud max-nextcloud added help wanted Extra attention is needed and removed good first issue Good for newcomers labels Jan 17, 2023
max-nextcloud added a commit that referenced this issue Jan 2, 2024
Fixes #2372.

We now have a different way of handling option workflow runs.
This allows to only run the workflows when needed
and require them to pass when they run.

Signed-off-by: Max <max@nextcloud.com>
max-nextcloud added a commit that referenced this issue Jan 2, 2024
Fixes #2372.

We now have a different way of handling option workflow runs.
This allows to only run the workflows when needed
and require them to pass when they run.

Signed-off-by: Max <max@nextcloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop enhancement New feature or request feature: integration help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants