Merge pull request #4945 from nextcloud/fix/toolbar_issues

fix(menubar): Code style fixes
nextcloud · Nov 7, 2023 · bdf3e31 · bdf3e31
2 parents a6e212f + 14c1f86
commit bdf3e31
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/src/components/Menu/MenuBar.vue b/src/components/Menu/MenuBar.vue
@@ -49,7 +49,7 @@
 			@keydown.right.stop="handleToolbarNavigation">
 			<!-- The visible inline actions -->
 			<component :is="actionEntry.component ? actionEntry.component : (actionEntry.children ? 'ActionList' : 'ActionSingle')"
-				v-for="actionEntry, index of visibleEntries"
+				v-for="(actionEntry, index) in visibleEntries"
 				ref="menuEntries"
 				:key="actionEntry.key"
 				:action-entry="actionEntry"
@@ -155,7 +155,7 @@ export default {
 	computed: {
 		visibleEntries() {
 			const list = this.entries.filter(({ priority }) => {
-				// if entry do not have priority, we assume it aways will be visible
+				// if entry has no priority, we assume it always will be visible
 				return priority === undefined || priority <= this.iconsLimit
 			})
 

diff --git a/src/components/Menu/ReadonlyBar.vue b/src/components/Menu/ReadonlyBar.vue
@@ -5,7 +5,7 @@
 			class="text-readonly-bar__entries"
 			:aria-label="t('text', 'Editor actions')">
 			<component :is="actionEntry.component ? actionEntry.component : (actionEntry.children ? 'ActionList' : 'ActionSingle')"
-				v-for="actionEntry, index of visibleEntries"
+				v-for="(actionEntry, index) in visibleEntries"
 				ref="menuEntries"
 				:key="actionEntry.key"
 				:action-entry="actionEntry"

diff --git a/src/components/Menu/ToolBarLogic.js b/src/components/Menu/ToolBarLogic.js
@@ -16,7 +16,7 @@ export default defineComponent({
 	watch: {
 		visibleEntries() {
 			this.$nextTick(() => {
-				if (this.activeMenuEntry > this.visibleEntries.length || this.visibleEntries[this.activeMenuEntry].disabled) {
+				if (this.activeMenuEntry > this.visibleEntries.length || this.visibleEntries[this.activeMenuEntry]?.disabled) {
 					this.setNextMenuEntry()
 				}
 			})