fix: solve publicly shared document with hide download issue

Signed-off-by: Luka Trovic <luka@nextcloud.com>

cypress/e2e/share.spec.js

@@ -122,17 +122,4 @@ describe('Open test.md in viewer', function() {
 				cy.get('.modal-mask').should('not.exist')
 			})
 	})
-
-	it('Share a file with download disabled shows an error', function() {
-		cy.shareFileToUser('test.md', recipient, {
-			attributes: '[{"scope":"permissions","key":"download","enabled":false}]',
-		}).then(() => {
-			cy.login(recipient)
-			cy.visit('/apps/files')
-			cy.openFile('test.md')
-			cy.getModal().find('.empty-content__title').should('contain', 'Failed to load file')
-			cy.getModal().getContent().should('not.exist')
-		})
-	})
-
 })

cypress/e2e/workspace.spec.js

@@ -59,7 +59,7 @@ describe('Workspace', function() {
 		cy.get('.files-fileList').should('contain', 'README.md')
 		cy.get('#rich-workspace .ProseMirror')
 			.should('contain', 'Hello world')
-		cy.get('a[href*="/apps/files/recent"]')
+		cy.get('li[data-id="recent"] a.nav-icon-recent')
 			.click()
 		cy.get('#rich-workspace .ProseMirror')
 			.should('not.visible')

lib/Service/DocumentService.php

@@ -495,10 +495,6 @@ public function checkSharePermissions($shareToken, $permission = Constants::PERM
 		if (($share->getPermissions() & $permission) === 0) {
 			throw new NotFoundException();
 		}
-
-		if ($share->getHideDownload()) {
-			throw new NotPermittedException();
-		}
 	}
 
 	public function hasUnsavedChanges(Document $document) {