Merge pull request #5063 from nextcloud/bugfix/noid/hide-cursor-print

fix: Hide cursor in print output
nextcloud · Nov 30, 2023 · 72f1ff7 · 72f1ff7
2 parents ae92cf9 + 4c13b38
commit 72f1ff7
Show file tree

Hide file tree

Showing 4 changed files with 9 additions and 0 deletions.
diff --git a/cypress/e2e/print.spec.js b/cypress/e2e/print.spec.js
@@ -39,6 +39,8 @@ describe('Open print.md and compare print view', function() {
 
 		cy.getEditor().should('be.visible')
 		cy.getContent()
+			// Ensure cursor is not displayed to prevent flaky tests (flashing input cursor)
+			.invoke('css', 'caret-color', 'transparent')
 			.get('h1:not(.hidden-visually)').should('contain', 'Print test')
 			.should('be.visible')
 
@@ -56,6 +58,8 @@ describe('Open print.md and compare print view', function() {
 			.then(() => {
 				cy.getEditor().should('be.visible')
 				cy.getContent()
+					// Ensure cursor is not displayed to prevent flaky tests (flashing input cursor)
+					.invoke('css', 'caret-color', 'transparent')
 					.get('h1:not(.hidden-visually)').should('contain', 'Print test')
 					.should('be.visible')
 

diff --git a/cypress/snapshots/base/print.spec.js/print view in single-file share.png b/cypress/snapshots/base/print.spec.js/print view in single-file share.png
diff --git a/cypress/snapshots/base/print.spec.js/print view in viewer.png b/cypress/snapshots/base/print.spec.js/print view in viewer.png
diff --git a/src/css/print.scss b/src/css/print.scss
@@ -127,4 +127,9 @@
 			display: none;
 		}
 	}
+
+	.collaboration-cursor__caret,
+	.collaboration-cursor__label {
+		display: none;
+	}
 }