Skip to content

Commit

Permalink
Remove superfluous scrollbar caused by menububble
Browse files Browse the repository at this point in the history
When the menububble is prepared
it is rendered at the bottom of the page and hidden.
The `margin-bottom: -3px` causes it to create a scrollbar.

Once the menububble is shown
it is positioned on the screen
and the scrollbar is gone.
So only apply the `margin-bottom: -3px`
when the menububble is shown.

Signed-off-by: Azul <azul@riseup.net>
  • Loading branch information
azul committed Oct 20, 2021
1 parent 50a278b commit 2f4f6ba
Show file tree
Hide file tree
Showing 14 changed files with 20 additions and 19 deletions.
4 changes: 2 additions & 2 deletions js/editor-rich.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/editor-rich.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/editor.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/editor.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-files.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-files.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-public.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-public.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-text.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-text.js.map

Large diffs are not rendered by default.

4 changes: 2 additions & 2 deletions js/text-viewer.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion js/text-viewer.js.map

Large diffs are not rendered by default.

1 change: 1 addition & 0 deletions package-lock.json

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/components/MenuBubble.vue
Original file line number Diff line number Diff line change
Expand Up @@ -154,7 +154,6 @@ export default {
border-radius: var(--border-radius-large);
overflow: hidden;
padding: 0;
margin-bottom: -3px;
margin-left: 10px;
visibility: hidden;
opacity: 0;
Expand All @@ -165,6 +164,7 @@ export default {
&.is-active {
opacity: 1;
visibility: visible;
margin-bottom: -3px;
}
&__button {
Expand Down

0 comments on commit 2f4f6ba

Please sign in to comment.