Fix moving tasks back and forth #1694
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Raimund Schlüßler <raimund.schluessler@mailbox.org>
Codecov Report
@@ Coverage Diff @@
## master #1694 +/- ##
=========================================
Coverage 29.90% 29.90%
Complexity 41 41
=========================================
Files 67 67
Lines 3076 3076
Branches 568 568
=========================================
Hits 920 920
Misses 2156 2156 |
|
I will close this since it's a server issue to be closed with nextcloud/server#30120. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first attempt to (hot-)fix moving tasks between lists, see #1685.
Requires nextcloud/cdav-library#514 for actually sending the correct header to server.
Unfortunately, the server does not seem to respect neither the
X-NC-CalDAV-No-Trashbinheader nor the request to overwrite existing dav objects.So this will definitely need fixes on the server side. Until this is fixed in server, one can only delete the trash bin entry and then move the task back.