Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement chat permission #798

Merged
merged 3 commits into from
May 19, 2022
Merged

Implement chat permission #798

merged 3 commits into from
May 19, 2022

Conversation

nickvergessen
Copy link
Member

@nickvergessen nickvergessen commented May 19, 2022 •
edited
Loading

Fix #767

  • Hide message input
  • Hide reaction option
  • Hide delete option
  • Don't show room in the list shown when trying to share something to talk

nickvergessen and others added 2 commits May 19, 2022 10:53
@nickvergessen
Implement chat permission
01cbfbf 
Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen
Show an alert when trying to share to a read-only or blocked conversa…
3ff8a53 
…tion

Signed-off-by: Joas Schilling <coding@schilljs.com>
@nickvergessen nickvergessen requested review from SystemKeeper and Ivansss and removed request for SystemKeeper May 19, 2022 08:54
@nickvergessen nickvergessen marked this pull request as ready for review May 19, 2022 08:55
@Ivansss
Always allow to delete messages that failed to be sent.
00a8215 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
Ivansss
Ivansss approved these changes May 19, 2022
View reviewed changes
Copy link
Member

@Ivansss Ivansss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @nickvergessen :)

@Ivansss Ivansss merged commit e4a46e6 into master May 19, 2022
@Ivansss Ivansss deleted the feature/767/chat-permission branch May 19, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ivansss Ivansss Ivansss approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees
No one assigned
Labels
3. to review enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Respect "🛃 Chat permission" for 25
2 participants
@nickvergessen @Ivansss