Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avatar hovercard #654

Merged
merged 5 commits into from
Nov 2, 2021
Merged

Avatar hovercard #654

merged 5 commits into from
Nov 2, 2021

Conversation

Ivansss
Copy link
Member

@Ivansss Ivansss commented Oct 26, 2021

iPhone

IMG_E0106

iPad

IMG_E0026

Fix #650

@Ivansss
Add tap gesture recognizer to chat cells' avatar.
c32e143 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Show user actions when tapping on avatar.
7f2e35b 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Add new user icon.
664f26f 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss
Include possible other user actions.
d7025c3 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@Ivansss Ivansss mentioned this pull request Oct 28, 2021
Merged
alazarevic5
alazarevic5 suggested changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@alazarevic5 alazarevic5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The menu (alert with options) should not be shown when I click on my own avatar.

@Ivansss
Show hovercard just for actorType==users and not to app user.
6d07c9d 
Signed-off-by: Ivan Sein <ivan@nextcloud.com>
@alazarevic5 alazarevic5 closed this Nov 2, 2021
@alazarevic5 alazarevic5 reopened this Nov 2, 2021
alazarevic5
alazarevic5 approved these changes Nov 2, 2021
View reviewed changes
Copy link
Contributor

@alazarevic5 alazarevic5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now it works as expected

@Ivansss Ivansss merged commit 8a90e88 into master Nov 2, 2021
@delete-merged-branch delete-merged-branch bot deleted the avatar-hovercard branch November 2, 2021 17:08
@thisIsTheFoxe thisIsTheFoxe mentioned this pull request Nov 8, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alazarevic5 alazarevic5 alazarevic5 approved these changes

@SystemKeeper SystemKeeper Awaiting requested review from SystemKeeper

Assignees
No one assigned
Labels
3. to review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Avatar "hovercard"
2 participants
@Ivansss @alazarevic5