Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(notifications): disable sounds on DND #674

Merged
merged 4 commits into from
Jun 10, 2024
Merged

fix(notifications): disable sounds on DND #674

merged 4 commits into from
Jun 10, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented May 25, 2024 •
edited
Loading

☑️ Resolves

🚧 Tasks

  • Add utils to set InitialState
  • On user status update change playSound configuration of notifications app
    • Defined by initial state
  • Also disable native notification sound as we always have out custom sound

@ShGKme ShGKme added bug Something isn't working 3. to review labels May 25, 2024
@ShGKme ShGKme self-assigned this May 25, 2024
@ShGKme ShGKme requested a review from nickvergessen June 5, 2024 15:38
DorraJaouad
DorraJaouad approved these changes Jun 8, 2024
View reviewed changes
Copy link

@DorraJaouad DorraJaouad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ShGKme
refactor: add initialState service
f6e7743 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(notifications): disable sounds on DND
11af9d0 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(notifications): disable native notification sound
834bc49 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
fix(UserStatus): emit user_status:status.updated on init
d504e23 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme
Copy link
Contributor Author

ShGKme commented Jun 10, 2024

Rebased onto main and squashed

@ShGKme ShGKme enabled auto-merge June 10, 2024 13:14
@ShGKme ShGKme merged commit deb7bf0 into main Jun 10, 2024
6 checks passed
@ShGKme ShGKme deleted the fix/disable-sound-on-dnd branch June 10, 2024 16:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickvergessen nickvergessen nickvergessen left review comments

@DorraJaouad DorraJaouad DorraJaouad approved these changes

@Antreesy Antreesy Awaiting requested review from Antreesy

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

notification sounds do not respect Do Not Disturb user status
3 participants
@ShGKme @nickvergessen @DorraJaouad