Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: show main window after login #623

Merged
merged 1 commit into from
Apr 18, 2024
Merged

fix: show main window after login #623

merged 1 commit into from
Apr 18, 2024

Conversation

ShGKme
Copy link
Contributor

@ShGKme ShGKme commented Apr 18, 2024

☑️ Resolves

  • Previously, after logging in the main window was minimized to the system tray
  • Now it is opened
  • No changes for launching app being logged in

@ShGKme
fix: show main window after login
90fe8ac 
Signed-off-by: Grigorii K. Shartsev <me@shgk.me>
@ShGKme ShGKme added bug Something isn't working 3. to review labels Apr 18, 2024
@ShGKme ShGKme self-assigned this Apr 18, 2024
Antreesy
Antreesy approved these changes Apr 18, 2024
View reviewed changes
Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, so that's why it happened (noticed recently on Mac machine 👀)

Tested on Linux, seems to be more reliable now. Although there's one nitpick, related to the process, it seems to be broken on server side:
image

@ShGKme
Copy link
Contributor Author

ShGKme commented Apr 18, 2024

Although there's one nitpick, related to the process, it seems to be broken on server side:

Yeah, that's server side

@ShGKme ShGKme merged commit 5a96684 into main Apr 18, 2024
6 checks passed
@delete-merged-branch delete-merged-branch bot deleted the fix/show-main-window-after-login branch April 18, 2024 17:38
@ShGKme ShGKme mentioned this pull request Apr 19, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Antreesy Antreesy Antreesy approved these changes

@DorraJaouad DorraJaouad Awaiting requested review from DorraJaouad

Assignees

@ShGKme ShGKme

Labels
3. to review bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ShGKme @Antreesy