Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update mine type icons #3719

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Update mine type icons #3719

merged 1 commit into from
Mar 19, 2024

Conversation

AndyScherzinger
Copy link
Member

Companion PR to nextcloud/android#12687 also adding proper SPDX headers to the changed files

🏁 Checklist

  • ⛑️ Tests (unit and/or integration) are included or not needed
  • 🔖 Capability is checked or not needed
  • 🔙 Backport requests are created or not needed: /backport to stable-xx.x
  • 📅 Milestone is set
  • 🌸 PR title is meaningful (if it should be in the changelog: is it meaningful to users?)

@AndyScherzinger AndyScherzinger added the 3. to review Waiting for reviews label Mar 16, 2024
@AndyScherzinger AndyScherzinger added this to the 19.0.0 milestone Mar 16, 2024
@AndyScherzinger AndyScherzinger mentioned this pull request Mar 16, 2024
Closed
3 tasks
@AndyScherzinger AndyScherzinger changed the title Feature/noid/update mine type icons Update mine type icons Mar 16, 2024
@AndyScherzinger AndyScherzinger force-pushed the feature/noid/updateMineTypeIcons branch 3 times, most recently from 7d21d98 to fa9eaf7 Compare March 17, 2024 16:57
@SystemKeeper SystemKeeper mentioned this pull request Mar 17, 2024
Closed
@AndyScherzinger AndyScherzinger force-pushed the feature/noid/updateMineTypeIcons branch from fa9eaf7 to f7ed268 Compare March 17, 2024 20:03
@AndyScherzinger @mahibi
Update mimetype icons
8280479 
Signed-off-by: Andy Scherzinger <info@andy-scherzinger.de>
@mahibi mahibi force-pushed the feature/noid/updateMineTypeIcons branch from f7ed268 to 8280479 Compare March 19, 2024 12:37
@mahibi mahibi merged commit 2561ae5 into master Mar 19, 2024
14 of 16 checks passed
@mahibi mahibi deleted the feature/noid/updateMineTypeIcons branch March 19, 2024 12:38
@github-actions GitHub Actions
Copy link
Contributor

Codacy

Lint

TypemasterPR
Warnings8181
Errors1010

SpotBugs

CategoryBaseNew
Bad practice66
Correctness99
Dodgy code112112
Internationalization33
Malicious code vulnerability33
Performance66
Security11
Total140140

@github-actions GitHub Actions
Copy link
Contributor

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/3719-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

@mahibi mahibi mentioned this pull request Apr 18, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mahibi mahibi mahibi approved these changes

@rapterjet2004 rapterjet2004 Awaiting requested review from rapterjet2004

@sowjanyakch sowjanyakch Awaiting requested review from sowjanyakch

Assignees
No one assigned
Labels
3. to review Waiting for reviews
Projects
None yet
Milestone
19.0.0
Development

Successfully merging this pull request may close these issues.
2 participants
@AndyScherzinger @mahibi