-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add API #7
Comments
And if possible with a permissions management in order to have access only in public reading too. |
Hey @datenangebot - I am interested in writing an Android client and I am wondering whether a public REST API has already been provided (and just not been documented yet)? |
Public sharing is not yet implemented. It is on the roadmap, but is not related to this issue. |
@stefan-niedermann Thanks for your issue comment. It's exactly what I am working on. All the changes are prepared in a pull request. Feel free to checkout and comment something: And by the way, having an mobile app for tables will be very interesting! |
Awesome! I'll have a look at it 🚀 |
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
This comment was marked as resolved.
this plugin is fun! I'll call it nextbase :) do you plan on taking row level writes through the API, so it would be in scope of #170 or you'll handle this separately? |
Yes, I am implementing it at this time... stay tuned. |
How will we handle API versioning?
|
There is the first API version, that will be extended from time to time. The new functions are shipped with the tables app versions. But existing methods will (hopefully) never change. So API v1 will be stable forever. If we need something new, not just an addition, we create API v2... Sorry, but what do you mean with "API version propagated"? |
Thanks for your explanations!
Sure 😄 😉
Then how will clients be able to know that they can use the "additions" if there is no minor update of the API version to v1.1?
Well, the API version will change over the time - either backwards compatible (for example by adding new endpoints without touching the existing ones) or incompatible (removing deprecated endpoints or change the way how they work). Let's assume you add a new endpoint which allows faster or more specific data access, the client will need to know when it can use it and when it needs to fall back to the older API endpoints. By "propagating" I mean, that the client needs to know the concrete API version (major and minor), to be able to prevent unexpected responses or notice the user that the support for the currenlty used server app version will be dropped soon. The server app needs therefore to propagate the current API version for example by appending it as a response header in each request (Notes app does this) or adding this information to the Nextcloud Hope I made clear what I mean, but in doubt we can also have a short talk on |
Actually I would be fine with just providing the Tables App version (
{
"ocs": {
"meta": {
"status": "ok",
"statuscode": 200,
"message": "OK"
},
"data": {
"version": {
"major": 25,
"minor": 0,
"micro": 5,
"string": "25.0.5",
"edition": "",
"extendedSupport": false
},
"capabilities": {
"deck": {
"version": "1.8.3",
"canCreateBoards": true,
"apiVersions": [
"1.0",
"1.1"
]
},
"notes": {
"api_version": [
"0.2",
"1.3"
],
"version": "4.7.2"
}
// ADD TABLES INFORMATION HERE
}
}
}
} |
Am I mistaken if I say the client don't need to know that? The developer has to know what endpoints can be used and the mobile app (or whatever) has to define the minimum supported tables version. Thanks for the explanations. I will have a look if I can easily add the tables api capabilities to the nc API capabilities. |
@stefan-niedermann Could look like this, would that be helpful? |
Yes, absolutely perfect! And you are right, the app version ( |
waiting for #215 before closing this issue |
# This is the 1st commit message: feat: create and edit rows from tables interactive widget Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #2: fix: set store in widget Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #3: fix: properly access store to create new row Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #4: fix: search functionality Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #5: fix: row reactivity Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #6: feat: add component testing skeleton files Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #7: test: start component testing for content reference widget Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #8: fix: point package.json scripts to webpack.config.js Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #9: fix(test): properly mount component Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #10: fix(test): use default options and mix in given mount options Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #11: fix(tests): add styles for components Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #12: refactor(tests): move richObject to fixture Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #13: test: verify table title after mounting component Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #14: test: test searching in widget Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #15: refactor(tests): organize mount test Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #16: fix: resolve pagination issues Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #17: fix: change viewport dimensions in cypress config Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de> # This is the commit message #18: fix: refine row selector Signed-off-by: Elizabeth Danzberger <lizzy7128@tutanota.de>
Provide access to manipulate tables, columns and rows via api
Adding doc for usage
The text was updated successfully, but these errors were encountered: