Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[stable26] feat: add utils for generating absolute links and copy a chat link #9141

Merged
merged 4 commits into from
Mar 23, 2023

Conversation

backportbot-nextcloud[bot]
Copy link

backport of #9051

- Add `generateAbsoluteUrl` util
- Add `copyLinkToConversation` method for copying conversation links to the clipboard with dialogs
- Remove unused
- Use dialogs on new conversation confirmation

Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Signed-off-by: Grigorii Shartsev <grigorii.shartsev@nextcloud.com>
Copy link
Member

@nickvergessen nickvergessen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Regression: the entries in the left sidebar are not linking to the rooms anymore, so you can no longer right-click => open in a new tab.

@ShGKme
Copy link
Contributor

ShGKme commented Mar 23, 2023

Regression: the entries in the left sidebar are not linking to the rooms anymore, so you can no longer right-click => open in a new tab.

I cannot reproduce

Copy link
Contributor

@Antreesy Antreesy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also can't reproduce the bug. Works fine on Firefox and Chrome

@nickvergessen
Copy link
Member

It's actually a regression from the Vue lib update i was testing before and I forgot to npm ci, sorry for the noise....

$ git bisect bad
a1e77c3bd934b9c5b2bbd44fda9bbba808663e41 is the first bad commit
commit a1e77c3bd934b9c5b2bbd44fda9bbba808663e41
Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
Date:   Thu Mar 23 16:43:04 2023 +0000

    Build(deps): Bump @nextcloud/vue from 7.8.0 to 7.8.2
    
    Bumps [@nextcloud/vue](https://github.com/nextcloud/nextcloud-vue) from 7.8.0 to 7.8.2.
    - [Release notes](https://github.com/nextcloud/nextcloud-vue/releases)
    - [Changelog](https://github.com/nextcloud/nextcloud-vue/blob/master/CHANGELOG.md)
    - [Commits](https://github.com/nextcloud/nextcloud-vue/compare/v7.8.0...v7.8.2)
    
    ---
    updated-dependencies:
    - dependency-name: "@nextcloud/vue"
      dependency-type: direct:production
      update-type: version-update:semver-patch
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>

 package-lock.json | 217 ++++++++++++++++++++++++++++++++++++++++++++++++------
 package.json      |   2 +-
 2 files changed, 196 insertions(+), 23 deletions(-)

@nickvergessen
Copy link
Member

Moved to #9153

@nickvergessen nickvergessen merged commit f0d428b into stable26 Mar 23, 2023
@nickvergessen nickvergessen deleted the backport/9051/stable26 branch March 23, 2023 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants